Test/coverage batch 2 - #2
Merged
Merged
Conversation
GetIconsForCategory called categoryName.Contains(...) unguarded, so a null category name threw NullReferenceException instead of using the "Allgemein" fallback that empty and unmatched names already get. Found by the new CategoryIcons test suite; pinned by a regression test there.
…rations ~670 new tests across the six remaining large service clusters: - Auth/WebAuthn (143): AuthService session restore, logout, 2FA, magic link, passkey login, IP-access branches; WebAuthnService driven with byte-accurate CBOR/COSE payloads and real P-256 keypairs through the hand-rolled parser and ECDSA verification, including DER signatures. - Backup cluster (93): BackupManagementService, KeyBackupService, JsonBackupHelper, DatabaseRestoreService up to their live-server and relational-provider seams. - ML cluster (95): SecurityRiskService, AnomalyDetectionService, CategoryPredictionService including tests pinning the currently broken ML training pipeline (schema mismatch on every reload). - Reporting/Import/Export (100): ApplicationInsightsService, ExportService, ImportService. - Database/GDPR (152): DatabaseHealthService (real relational paths via shared in-memory SQLite), DatabaseProviderService, GdprCleanupService, RateLimitService extended 7 -> 37. - PDF/Integrations (134): PdfReportService fully covered (800/800), OllamaService, CloudflareService, CategoryIcons. Several tests intentionally document currently-broken production behavior (encrypted-backup restore, backup retention date math, WebAuthn origin/counter checks, storage-location Excel export) rather than asserting the intended behavior - candidates for follow-up fixes. Coverage: 42% -> 73.7% (19880/26948 lines, CI measurement filters).
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test coverage batch 2