fix: point docker-compose at the real public GHCR image, drop dead re… - #1
Merged
Conversation
…gistry prompts docker-compose.yml's server.image hardcoded the placeholder registry.example.com/studylife/server:latest, which does not exist - following the documented Quick Start (./setup.sh) would fail outright trying to pull it. The image CI/CD actually builds and publishes is the public ghcr.io/lukislp/studylife-server (verified pullable with no login via `docker manifest inspect`). - docker-compose.yml: image now defaults to ghcr.io/lukislp/studylife-server:latest, overridable via SERVER_IMAGE for anyone self-hosting their own fork on their own registry. - setup.sh: only prompts for/logs into a registry when REGISTRY_URL/USER/PASSWORD are explicitly set; the default path pulls the public image with zero prompts. - .env.example: documents SERVER_IMAGE/REGISTRY_* as an optional override instead of a required private-registry flow. - README.md: CI/CD Pipeline table replaced with the real GitHub Actions jobs from .github/workflows/ci-cd.yml (it previously described a stale GitLab CI stage/job layout that hasn't run since the move off GitLab); Deployment/Environment Variables and remaining GitLab mentions updated to match current reality.
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-compose.yml's server.image hardcoded the placeholder registry.example.com/studylife/server:latest, which does not exist - following the documented Quick Start (./setup.sh) would fail outright trying to pull it. The image CI/CD actually builds and publishes is the public ghcr.io/lukislp/studylife-server (verified pullable with no login via
docker manifest inspect).