fix: address full code review findings - #1
Merged
Merged
Conversation
Preserve YAML during symbol renames, make analysis scope-aware, harden secret detection and cancellation, and prevent partial public releases. Add regression coverage for the corrected edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Zapracovává všechny nálezy z opakovaného code review a doplňuje regresní pokrytí rizikových cest.
Rename correctness
Analysis and security
Cancellation and release reliability
pacdetection, unpack a pack propagují cancellation; child process se po kill korektně drainuje.Type
PAxxxx)Test coverage
pacdetection and SourcePreparer cleanup.Remaining integration gaps are the real external
pacround-trip withoutEASEL_TEST_MSAPP, solution ZIP cleanup failure paths, and live GitHub release finalization.Pre-landing review
Independent security, maintainability, testing, performance and adversarial re-review: no remaining findings.
Five findings discovered during the first ship review were fixed before commit and received dedicated regression coverage.
Plan completion
No relevant plan artifact was found; audit skipped.
Documentation
docs/rename.mdnow describes identifier-aware renaming, supported symbol kinds, preserved YAML formatting and intentionally unchanged string literals.Checklist
dotnet buildis warning-clean (0 warnings, 0 errors)dotnet testpasses (123/123)dotnet format --verify-no-changespassesosx-arm64publish succeedsCleanApprelease.ymlparses as valid YAMLNotes for reviewers
Please focus on exact YAML source-span handling in
RenameEngine, scoped control identity inDiffEngine, and formula-vs-literal handling in the secrets pipeline.