refactor(e2e)!: fold the profile algorithms onto simple-e2e (0.13.0) - #154
Draft
JustinKovacich wants to merge 5 commits into
Draft
refactor(e2e)!: fold the profile algorithms onto simple-e2e (0.13.0)#154JustinKovacich wants to merge 5 commits into
JustinKovacich wants to merge 5 commits into
Conversation
E2ECheckStatus::{CrcError, BadArgument} become Invalid(E2EValidateError),
carrying the profile's real ValidateError (received/computed CRC on a
mismatch). Return codes are unchanged: CRC mismatch -> 2, every other
validation failure -> 6. Configs, states, header sizes, and the six
check_*/protect_* entry points keep their names as aliases/adapters.
…p the direct crc dep
… lane resolves it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes this crate's private E2E Profile 4/5 implementation (~2,000 lines) in favor of the
simple-e2ecrate, and givesE2ECheckStatusa realInvalid(E2EValidateError)in place of the taglessCrcError/BadArgument. Wire return codes unchanged. See the[0.13.0]CHANGELOG section for the migration table.Kept in this crate:
E2EKey,E2EProfile, the(source, key)registry and its caps,E2ERegistryHandle,e2e::Error.Draft until
simple-e2e0.1.0 is on crates.io (luminartech/simple_e2e#4) — the rootCargo.tomlstill carries a[patch.crates-io]path override for local development; the final commit removes it.SemVer Checkis expected to fail (intentional major bump under 0.x).Local verification: clippy pedantic clean across all five CI feature sets and the nightly bare-metal-runtime lane; 472 lib + 14 doc tests green;
thumbv7em-none-eabihfbuilds. Theclient_serverintegration suite fails on this dev box identically onorigin/main(multicast subscription never registers here), so it's left to CI.