a11y: colorblind-safe default palette with dual-encoded status - #614
a11y: colorblind-safe default palette with dual-encoded status#614AgileInnov8tor wants to merge 2 commits into
Conversation
Replace Tokyo Night / 16-color traffic lights with a shared Okabe–Ito semantic theme (truecolor plus 16-color fallback). Status uses words or ASCII glyphs as well as hue; provider labels stay uncolored. --no-color and NO_COLOR still strip ANSI. Preview: docs/cvd-palette-preview.html
Inverse and neon accent bars read poorly in Warp. Paint a dark canvas, use a navy wash for the cursor, keep Okabe-Ito hues on labeled stats and effort, and mark the active scope with [brackets] instead of a filled chip.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1e716b7d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (useTrueColor()) { | ||
| const [r, g, b] = hexToRgb(roles[role]); | ||
| return `\x1b[38;2;${r};${g};${b}m${s}\x1b[0m`; |
There was a problem hiding this comment.
When COLORTERM advertises truecolor but the terminal uses a light background, this emits the fixed dark-tuned RGB palette without setting or detecting the background. Colors such as #E8E8E8, #56B4E9, and #2BC48A have very low contrast against white, making substantial CLI output faint or unreadable; retain terminal-configurable ANSI colors for CLI output or select a palette based on the terminal background.
Useful? React with 👍 / 👎.
| case "max": | ||
| return theme.accentAlt; | ||
| default: | ||
| return theme.fgDim; |
There was a problem hiding this comment.
Skills with the supported effort: xhigh value fall through to theme.fgDim, so this newly color-coded column renders a high-effort setting like an unset or unknown value. The evaluator explicitly accepts xhigh in src/eval/providers/skill-best-practice/v1/index.ts:28-30; add an xhigh case with an appropriate high-effort color.
AGENTS.md reference: AGENTS.md:L68-L74
Useful? React with 👍 / 👎.
| case "dangerous": | ||
| return color.bgRed(" DANGEROUS "); | ||
| return color.red("[!! DANGEROUS]"); |
There was a problem hiding this comment.
For valid installed skill names of 36–38 characters, the longer [!! DANGEROUS] badge makes this row exceed the formatter's fixed width even though the previous badge still fit, so its closing border no longer aligns with the rest of the security report. Installed names can be much longer under src/installer-core.ts:329-336; truncate the displayed name, widen the box, or account for the badge before enforcing the one-space minimum gap.
Useful? React with 👍 / 👎.
1 participant
Summary
Replaces Tokyo Night / saturated 16-color ANSI with an accessible Okabe–Ito semantic color palette (truecolor with high-contrast 16-color fallback) and dual-encoded status indicators.
[Active],[Disabled],!, checkmarks), ensuring full readability under monochrome, high-contrast, or color-blind viewing.[ ]for active filter scope instead of inverse neon blocks, avoiding glare in modern terminal emulators (Ghostty, Warp, iTerm2).--no-color/NO_COLORstripping and 16-color ANSI fallbacks.docs/cvd-palette-preview.html.Testing
All test suites pass cleanly: