feat(get): borrow full skill directories with explicit cleanup (#654) - #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #654
Summary
Adds persistent full-directory borrowing to
asm get --pathso ephemeral callers receive supporting scripts, templates, references, and binary assets, plus an explicitasm cleanup <borrowed-path>command that only removes ASM-owned borrows.Approach
Thin borrowed-copy facade over the existing dependency-lease lifecycle (separate
get-borrowsnamespace); copy every source tier and require exact registered-path cleanup.Decision Record
asm getresolved complete skill directories but only emittedSKILL.md, then deleted the remote staging clone, leaving callers without referenced supporting files.Analyzed at:
feat/654-feature-asm-get-clone-full-skill @ 1fc84c0(2026-09-09)Changes
README.mdsrc/cli.tsget --pathparsing andcleanuprouting/helpsrc/cli.test.tssrc/commands/cleanup.ts--dry-runsrc/commands/get.tssrc/commands/get.test.tssrc/config.tssrc/dependency-leases.tssrc/dependency-leases.test.tssrc/formatter-core.tssrc/formatter.tssrc/get-borrows.tssrc/get-borrows.test.tssrc/utils/types.tsTest Results
Acceptance Criteria Verification
src/get-borrows.test.tsbinary/executable preservation; CLI test reads all files after process exitasm cleanup <borrowed-path>; second-process removal testasm getbehavior unchangedasm installfor permanent retention