Skip to content

fix(input): hardcoded width restrictions to fix horizontal scroll #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lupodevelop merged 2 commits into from
Jun 5, 2026
Merged

fix(input): hardcoded width restrictions to fix horizontal scroll #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f562a
#3: fix(input): remove hardcoded width restrictions to fix horizontal…
salespaulo Jun 4, 2026
6af9c7a
fix(format): Check fail, try format again
salespaulo Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/etui/backend/erlang.gleam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ fn init_terminal(mouse: Bool) -> Result(ErlangTerminalState, Error) {
enter_raw_ffi()
set_raw_state(True)
let #(cols, rows) = case window_size_ffi() {
Ok(#(c, r)) -> #(c, r)
Error(_) -> #(80, 24)
Ok(#(c, r)) -> #(c - 1, r)
Error(_) -> #(79, 24)
}
install_sigint_cleanup_ffi(fn() { terminal_cleanup() })
Ok(ErlangTerminalState(
Expand Down Expand Up @@ -144,12 +144,12 @@ fn poll_input(
}
case window_size_ffi() {
Ok(#(c, r)) ->
case c == state.cols && r == state.rows {
case c - 1 == state.cols && r == state.rows {
True -> Ok(#(input_event, state))
False ->
Ok(#(
backend.Resize(c, r),
ErlangTerminalState(..state, cols: c, rows: r),
backend.Resize(c - 1, r),
ErlangTerminalState(..state, cols: c - 1, rows: r),
))
}
Error(_) -> Ok(#(input_event, state))
Expand All @@ -160,8 +160,8 @@ fn get_terminal_size(
state: ErlangTerminalState,
) -> Result(#(TerminalSize, ErlangTerminalState), Error) {
case window_size_ffi() {
Ok(#(w, h)) -> Ok(#(backend.TerminalSize(width: w, height: h), state))
Error(_) -> Ok(#(backend.TerminalSize(width: 80, height: 24), state))
Ok(#(w, h)) -> Ok(#(backend.TerminalSize(width: w - 1, height: h), state))
Error(_) -> Ok(#(backend.TerminalSize(width: 79, height: 24), state))
}
}

Expand Down
13 changes: 11 additions & 2 deletions src/etui/widgets/input.gleam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import etui/buffer
import etui/geometry
import etui/style
import etui/text
import gleam/int
import gleam/string

// ─────────────────────────────────────────────────────────────────
Expand Down Expand Up @@ -228,8 +229,16 @@ pub fn render(
True -> widget.prompt <> value_display
False -> widget.prompt <> widget.placeholder
}
let truncated = text.truncate(display_text, area.size.width - 1, "")
let padded = text.pad_right(truncated, area.size.width)
let c = text.cell_width(widget.prompt) + state.cursor
let w_avail = int.max(1, area.size.width)
let view_start = case c >= w_avail {
True -> c - w_avail + 1
False -> 0
}
let prefix = text.truncate(display_text, view_start, "")
let suffix = string.drop_start(display_text, string.length(prefix))
let truncated = text.truncate(suffix, w_avail, "")
let padded = text.pad_right(truncated, w_avail)
let modifier = case has_value {
True -> style.bold()
False -> style.none()
Expand Down
Loading