fix(connectordiscoverymcp): wire /healthz readiness probe + ALB HC annotation#174
Merged
Merged
Conversation
…ng at /healthz The chart had no probes at all, so K8s reported the pod ready based on container start alone — which meant a misconfigured / crashing supergateway went undetected. Add readiness + liveness against /healthz (newly exposed by the connector-mcp image, see luthersystems/agent-builder PR companion). Closes the remaining part of #172.
…ervice Mirrors the pattern established in #173 for the other umbrella subcharts. ALB now probes /healthz (served by supergateway after the agent-builder companion PR ships :latest), flipping this TG to healthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the work started in #173 for the last laggard target group,
connectordiscoverymcp.readinessProbe+livenessProbeon the container, both hittingGET /healthzon thehttp(8000) port. Previously there were no probes at all, so K8s reported the pod ready immediately on container start — masking a misconfigured / crashing supergateway.Pairs with luthersystems/agent-builder#47 which adds
--healthEndpoint /healthzto the supergateway CMD inagent-builder/connector-mcp/Dockerfile. That PR is what actually makesluthersystems/connector-mcp-discovery:latestserveGET /healthz → 200 "ok".Closes #172.
DO NOT MERGE until upstream image ships
This PR must not be merged until:
luthersystems/connector-mcp-discovery:latestimage is live on Docker Hub.If merged before that, the next umbrella deploy will roll a pod where the supergateway does not serve
/healthz, the new readinessProbe will fail, the pod will never become Ready, and the ALB will pull traffic — taking the connector-discovery MCP surface down.Rendered locally via
helm templateto confirm both probe blocks and the annotation block come out with the right indentation.Test plan
:latestimage timestamp on Docker Hub.mars-versionin ui-infrastructure → deploy umbrella on testaws elbv2 describe-target-healthonk8s-ui-umbrella-9fb257ad5f→ all targetshealthykubectl -n ui exec deploy/umbrella-connectordiscoverymcp -- python3 -c 'import urllib.request; print(urllib.request.urlopen("http://localhost:8000/healthz", timeout=2).read())'→b'ok'