Expanded Long Description Box - #72
Merged
Merged
Conversation
* adding delete icon * added basic delete functionality * able to delete cards but need to clear selections * finished adding delete feature * added comment * updating exported graph as well * added deletedIndices to widget * fixed update bug in export and deletion buttons * fixed keeping track of deletions between exports * fixed bug to have exportedIndices sync on delete * changed logic to use observer in backend * implemented button to set intent + deletion bug fix * added interfaces * removed alert for intent * changed icon to magnifying glass * updated intent btn message * changed variable names * Update buttonsBroker.tsx minor edits to text label * Update buttonsBroker.tsx * change mentions of cards to visualizations * fixed jupyter labextensionn install * initial fix for jupyter lab compatibility * cleaned up code * changed lux-widget to luxwidget * small updates * changed phosphor to lumino and updated dependencies for lab 2 * overwrote one of the jupyter's css styles * moved lumino to dev dependency * lowercased lumino * reduced react version requirement and fixed typing bug * added documentation for users and developers * Update CONTRIBUTING.md * fixed minor css issues * change installation instructions for PyPI * wording on installation * Update README.md * changed version numbers to 0.1.1 * added installation for luxwidget * merging master Co-authored-by: Doris Lee <dorisjunglinlee@gmail.com>
dorisjlee
changed the title
dorisjlee
approved these changes
Mar 4, 2021
Member
|
Hey @jerrysong1324, The changes here looks good! I'm also assigning @cjachekang as a reviewer. |
Contributor
|
@dorisjlee this can be merged in first - also, are we always merging in the index.js/index.js.map files? |
jacquekang
approved these changes
Mar 4, 2021
Contributor
Author
|
My understanding is that we are merging in the index.js/index.js.map files right? I thought I asked Doris before and that's what she said. |
Member
|
Yeah we are merging the index.js files since these compiled files are what the nbextension uses for non-dev installs (e.g. binder and PyPI releases). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #67
Changed
Screenshots