Skip to content

Swift6 support#13

Open
lvalenta wants to merge 4 commits into
mainfrom
sending-closures
Open

Swift6 support#13
lvalenta wants to merge 4 commits into
mainfrom
sending-closures

Conversation

@lvalenta

Copy link
Copy Markdown
Owner

No description provided.

@Ashok28 Ashok28 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, feel free to merge after resolving.

self.init(services: [service])
}

#if hasFeature(SendingArgsAndResults)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you've updated manifest to require Swift6, this and the whole #else branch can be removed, since SE-0430 was merged.

let endIndexByLevel: [LogLevel: Int]

var isEmpty: Bool { sortedServices.isEmpty }
var allServices: [LoggerService] { sortedServices }

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems kinda redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants