Fix/CI: Handle potential null, add Miri to CI #50
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the PAM cleanup callback against a possible null data pointer (preventing UB when constructing Box<T> from a null raw pointer) and adds a CI job to run Miri so similar issues are caught automatically.
Changes:
- Add a defensive
nullcheck incleanup<T>beforeBox::from_raw. - Extend/rename the unit test to cover “null data” and panic-on-drop disaster scenarios.
- Add a GitHub Actions Miri job and adjust doc-test comment wording.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pam/src/module.rs |
Adds null guarding in the PAM cleanup callback and updates tests to cover the null case. |
.github/workflows/rust.yml |
Introduces a Miri CI job to detect UB in tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data argument supplied to the cleanup callback we hand to PAM can technically be null. This shouldn't normally happen (given the whole point of the cleanup callback), but the possibility needs to be handled regardless. This was actually caught by running miri on the test update included in this PR:
Not unrelatedly, this PR also updates CI to add a miri test job.