Initial commit for json serialization

[vikramkadi]

No description provided.

[djnym]

I don't think the changes here are correct. I think that instead of keeping around another structure, you should instead just convert in this function. It may require deserializing and then converting to json. @pfarner may have a similar opinion, but hopefully he'll see this.

[vikramkadi]

I removed the extra structure i was using to hold attributes.

[pfarner]

I'm not a JSON expert, so I'm hoping that there's a good reason to have three different JSON formats. I get why one might have typed and untyped, but how does the default one differ from the typed one?

I see that a strings have escaped quotes placed inside their values, but only in some formats. If we have a simple event containing only a string field, here are the JSON formats:

X { enc = 1; string = contents; }

default JSON (with two copies of the data, one with extra double-quotes, the other without):
{"name":"X","attributes":{"EventName":"X","string":"contents","enc":1},"typed":{"string":{"type":"string","value":""contents""},"enc":{"type":"int16","value":"1"}}}

typed (with extra double-quotes):
{"name":"X","typed":{"string":{"type":"string","value":""contents""},"enc":{"type":"int16","value":"1"}}}

untyped (no extra double-quotes):
{"name":"X","attributes":{"EventName":"X","string":"contents","enc":1}}

It seems like none of these should have the escaped double quotes within their double-quoted values.

[pfarner]

It gets even weirder if I use single- or double-quote characters within the string value:

Event:
X { enc = 1; string = '"; }

default JSON:
{"name":"X","attributes":{"EventName":"X","string":"\u0027"","enc":1},"typed":{"string":{"type":"string","value":""\u0027\"""},"enc":{"type":"int16","value":"1"}}}

{"name":"X","typed":{"string":{"type":"string","value":""\u0027\"""},"enc":{"type":"int16","value":"1"}}}

{"name":"X","attributes":{"EventName":"X","string":"\u0027"","enc":1}}

The single quote is converted to unicode, and the rest of the string contents (particularly the double-quote) are getting escaped twice. I can't imagine that this is by design.

[pfarner]

We should also add a "version":1, outside the attributes section, so we can change the format later.

[vikramkadi]

Preston,
I have added the version attribute, Also fixed the issue with the unicode escaping of characters.
As far as escaping double quotes, i think json standard is to escape using backslash.
Also i have moved the attributes part into the Queasy plugin for lwes.

[djnym]

@pfarner any further comments on Vikram's changes? Otherwise, I'd like to but a bow on this request, and get it merged, and hopefully pushed to maven central.

[pfarner]

Minor, but this is an unnecessary line; it could just fall through to the next case.