fix syntax to work with ansible 2.19+#94
Merged
Conversation
gregoryguillou
force-pushed
the
fix/boolean-conditions
branch
from
02bc76a to
4a95268
Compare
Signed-off-by: Gregory Guillou <gregory@resetlogs.com>
Signed-off-by: Gregory Guillou <gregory@resetlogs.com>
stgraber
force-pushed
the
fix/boolean-conditions
branch
from
4a95268 to
c7d423c
Compare
stgraber
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes on top of "manage deprecation and move to proper variables" and needs to be rebased to pass.
Ansible 2.19+ is more strict. Some roles have been modified to reflect the new requirements:
whencondition predicates must be true of false. For instanceincus_ovn_northboundwas simply tested as defined, now the code check is is actually defined and not empty with a proper conditiondelegate_tois now evaluated even if the condition prevent the code from being executed. This PR makes sure the associated code is valid.