feat: setting pages重构 by futurw4v · Pull Request #10 · lxdklp/FML

futurw4v · 2026-02-19T12:27:17Z

重构了SettingPage AboutPage ThemePage LogSettingPage LogViewerPage JavaPage，优化样式与代码结构
更改了about页面里的版权信息

重构后

关于视觉不统一与其他页面与代码复用：
不在这个PR的职责内，下个PR会提取出一些组件然后全局替换和做一些代码重构

futurw4v · 2026-02-19T12:49:29Z

关于页面在小窗口会有点溢出，现在最小窗口大小还不是很合理，不过我打算到时候用window_manager来定制窗口样式（去标题栏按钮等），也不在这个PR的职责内了，所以暂时先不管

Copilot

Pull request overview

This PR refactors the settings pages (SettingPage, AboutPage, ThemePage, LogSettingPage, LogViewerPage, JavaPage) to modernize the UI and improve code structure. The refactor adopts Material Design 3 principles with consistent card styling (elevation 0, outlined borders), replaces separate navigation with a unified drawer-based navigation pattern using IndexedStack for state preservation, and consolidates common styling patterns. The about page is also updated to use the global gAppVersion constant instead of reading from SharedPreferences.

Changes:

Implemented unified navigation drawer in SettingPage with IndexedStack for state preservation
Standardized card styling across all settings pages using MD3 guidelines (elevation: 0, outlined borders with colorScheme.outlineVariant)
Refactored ThemePage to use SegmentedButton for theme mode selection and improved color picker UI
Enhanced LogViewerPage with FutureBuilder pattern and centralized date formatting
Improved JavaPage with better variable naming and UI consistency
Updated AboutPage to use global gAppVersion constant and extracted helper method for card creation

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
lib/pages/setting_page.dart	Replaced card-based navigation with NavigationDrawer and IndexedStack; removed slide navigation
lib/pages/setting/theme.dart	Replaced switch-based UI with SegmentedButton; customized color picker to match MD3; changed dialog button from "确定" to "关闭"
lib/pages/setting/log_viewer/log_setting.dart	Updated Card styling to MD3 standards; improved layout of log level dropdown
lib/pages/setting/log_viewer.dart	Converted to FutureBuilder pattern; added centralized date formatting; removed loading state variable; improved UI layout
lib/pages/setting/java.dart	Renamed variables for clarity; refactored UI with consistent card styling; improved code organization with better documentation
lib/pages/setting/about.dart	Replaced _appVersion with gAppVersion; extracted _buildCardWithListTile helper method; updated card styling to MD3 standards

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-21T04:32:14Z

+            child: Text(
+              '设备上的Java列表',
+              style: Theme.of(context).textTheme.headlineMedium,


Java 页面原先 AppBar 上有“刷新”按钮，当前重构后 _refresh() 只在 initState() 调用一次，UI 上不再提供重新扫描/刷新 Java 列表的入口。这会导致用户安装/移除 Java 后只能重启应用才能更新列表。建议在标题区域增加一个刷新 IconButton（类似 LogViewer 的刷新），或提供下拉刷新等触发方式来调用 _refresh()。

Suggested change

child: Text(

'设备上的Java列表',

style: Theme.of(context).textTheme.headlineMedium,

child: Row(

mainAxisAlignment: MainAxisAlignment.spaceBetween,

children: [

Text(

'设备上的Java列表',

style: Theme.of(context).textTheme.headlineMedium,

),

IconButton(

icon: const Icon(Icons.refresh),

tooltip: '刷新',

onPressed: _refresh,

),

],

这一块可能会重写

futurw4v · 2026-02-21T04:36:55Z

啊我还没改好搜索java的（
我想的是遍历
但是每次启动都遍历有点吃性能

lxdklp · 2026-02-21T11:57:05Z

啊我还没改好搜索java的（
我想的是遍历
但是每次启动都遍历有点吃性能

搜索Java应该是只打开设置Java的页面才会去搜索吧，我原本的Java搜索是参考hmcl写的

futurw4v · 2026-02-22T02:38:34Z

最近没什么时间摸电脑T_T 所以这个可能会拖比较久

lxdklp · 2026-02-23T09:32:38Z

最近没什么时间摸电脑T_T 所以这个可能会拖比较久

没事，我最近也没啥空，甚至今年上半年因为实习之类的都没啥空，不出意外今年上半年最多只能再发一个版：（

将系统默认Java的标记从 'java' 改为 'default'（可能会有兼容问题）

futurw4v · 2026-03-07T00:32:06Z

Windows 四个磁盘（代码中排除了C，因为搜索常用目录个人认为足够）搜索深度4 搜索效果

当然现在只是个不完整的实现，没有写macos和linux的
留了个print输出搜索时间
现在还很不合理，因为IndexedStack的原因还没点进去打开应用就开始搜索，以及initState的时候就搜索后期会改

futurw4v · 2026-03-07T01:07:31Z

macos和linux我这没得测试，更改大致是这样

futurw4v · 2026-03-07T01:12:56Z

这个pr我觉得有点职责过重了，java留到下个pr先？

lxdklp · 2026-03-08T11:58:09Z

这个pr我觉得有点职责过重了，java留到下个pr先？

也可以,这个pr先把setting改完,java相关的另外再开pr吧

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-21T05:48:13Z

+              Expanded(
+                child: IndexedStack(
+                  index: _selectedIndex,
+                  children: _settingPageItems.map((item) => item.page).toList(),
+                ),


IndexedStack 会在首次 build 时构建所有子页面并触发它们的 initState。当前设置页的子项里包含 JavaPage（会启动 Java 扫描）和 LogViewerPage（会加载日志），这会让打开设置页就立刻执行这些耗时操作，即使用户没有切换到对应 tab。建议在这里也改用 LazyLoadIndexedStack（项目已在 main.dart 引入）或用 WidgetBuilder 延迟创建页面，避免不必要的初始化与性能开销。

个人认为打开页面之后加载子页面更合理点

lxdklp · 2026-03-21T06:07:11Z

-            SizedBox(width: 8),
-            Chip(label: Text(javaRuntime.info.vendor ?? 'Unknown')),
+            if (isCurrent) ...[
+              Chip(label: Text('当前')),


似乎也不是特别必要?毕竟已经有加深颜色作为视觉提示了,加多了一个反而让 Chip 数量对不齐

加深颜色对于当前的显示不太明显，我觉得应该找个更好的方案吧

futurw4v added 13 commits February 19, 2026 20:11

feat: 重构SettingPage的排版

382fd0a

chore(setting_page): 将“下载”改为“设置”

483edf6

feat: 重构ThemePage

429af46

feat: 重构JavaPage

a285078

feat: 使设置页面的标题对齐设置

0131ba9

refactor(JavaPage): 清理代码，优化代码结构和命名

4599aff

refactor: 用FutureBuilder重构LogViewerPage

cbc3262

refactor(LogViewerPage): 引入DateFormat格式化时间，重新设置代码格式

91eaddf

feat(LogViewerPage): 将标题行按钮组右对齐，更改卡片样式，添加视觉细节

a88c1df

refactor(about): 整理代码格式

59f0d80

feat(about): 更换卡片样式，更新版权年份

1f96374

feat(log_setting): 更换卡片样式，优化间距

2ac4ee7

fix: 移除多余括号，修复编译错误

e7cc7a8

Copilot AI reviewed Feb 19, 2026

View reviewed changes

futurw4v added 5 commits February 20, 2026 14:48

refactor: 用kDefaultPadding替换相应常量

cc52a69

feat(log_viewer): 为显示日志等级的容器添加内边距

04a4b1f

perf: 添加const标识符

cc8a470

fix(log_viewer): 清除日志后重新加载列表

eef4d74

fix(java_manager): 使用正确的PATH分隔符扫描Java可执行文件

79c4ce4

futurw4v force-pushed the feature/setting_page branch from 6724292 to fba6d2b Compare February 20, 2026 15:54

refactor(java_manager): 整理代码，提取与JavaPage相同的部分

29d0380

futurw4v force-pushed the feature/setting_page branch from fba6d2b to 29d0380 Compare February 20, 2026 15:54

Copilot AI reviewed Feb 21, 2026

View reviewed changes

futurw4v added 2 commits February 25, 2026 00:23

feat(java.dart): 优化Java卡片视觉，优化代码

19c3567

将系统默认Java的标记从 'java' 改为 'default'（可能会有兼容问题）

feat(java_manage): 为查找java添加递归，整理代码

545e539

feat(java.dart): 提取通用创建Card代码，为当前java添加Chip便于分辨

a6a6ac8

futurw4v added 3 commits March 15, 2026 10:05

feat: 添加LazyLoadIndexedStack使页面懒加载

4f94be1

feat(log_viewer): 使日志从新到旧显示

9b92579

chore(java_manage): 移除无用日志

189464d

futurw4v force-pushed the feature/setting_page branch from 856d8c1 to 189464d Compare March 15, 2026 05:39

Merge branch 'main' into feature/setting_page

ac5be15

futurw4v requested a review from lxdklp March 21, 2026 05:38

Copilot AI reviewed Mar 21, 2026

View reviewed changes

lxdklp reviewed Mar 21, 2026

View reviewed changes

Comment thread lib/pages/setting/theme.dart

lxdklp reviewed Mar 21, 2026

View reviewed changes

futurw4v added 3 commits March 21, 2026 14:18

fix(theme): 优化代码，修复主题切换不生效，优化颜色选中视觉风格

ae7433d

fix(log_viewer): 将顶部操作按钮与标题拆分并让部分按钮与FutureBuilder数据同步，优化代码格式

f81f8f0

refactor(java): 更改systemJavaInfo的空安全处理

9934af4

futurw4v requested a review from lxdklp March 28, 2026 04:25

lxdklp merged commit 5bdf1d3 into lxdklp:main Mar 28, 2026
1 check passed

futurw4v deleted the feature/setting_page branch March 28, 2026 12:16

-            child: Text(
-              '设备上的Java列表',
-              style: Theme.of(context).textTheme.headlineMedium,
+            child: Row(
+              mainAxisAlignment: MainAxisAlignment.spaceBetween,
+              children: [
+                Text(
+                  '设备上的Java列表',
+                  style: Theme.of(context).textTheme.headlineMedium,
+                ),
+                IconButton(
+                  icon: const Icon(Icons.refresh),
+                  tooltip: '刷新',
+                  onPressed: _refresh,
+                ),
+              ],

Conversation

futurw4v commented Feb 19, 2026

Uh oh!

futurw4v commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

futurw4v Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

futurw4v commented Feb 21, 2026

Uh oh!

lxdklp commented Feb 21, 2026

Uh oh!

futurw4v commented Feb 22, 2026

Uh oh!

lxdklp commented Feb 23, 2026

Uh oh!

futurw4v commented Mar 7, 2026

Uh oh!

futurw4v commented Mar 7, 2026

Uh oh!

futurw4v commented Mar 7, 2026

Uh oh!

lxdklp commented Mar 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

futurw4v Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lxdklp Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

futurw4v Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

futurw4v commented Feb 19, 2026 •

edited

Loading