fix(pdh): align PDH double and large counter values on windows/386#131
Open
xin77k wants to merge 1 commit into
Open
fix(pdh): align PDH double and large counter values on windows/386#131xin77k wants to merge 1 commit into
xin77k wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the layout of PDH formatted counter value specializations on 32-bit Windows.
Background
PDH_FMT_COUNTERVALUE is a native Windows structure containing a DWORD CStatus
followed by a union. In the current Go specialization, the 8-byte value fields
were defined immediately after CStatus, for example:
and
On windows/386 this can lead to a layout mismatch with the native PDH structure,
because the 8-byte union value may not be read from the correct offset.
Problem
On 32-bit Windows, PDH double counters could return obviously corrupted values,
such as extremely large or small numbers, even when:
This was observed when reading PDH formatted values through the Go
specialization structs.
Change
This PR adds explicit 4-byte padding after CStatus for 8-byte union members:
This keeps the 8-byte value fields aligned with the native PDH layout on
windows/386.
Impact
Notes
This issue was observed on windows/386 when reading PDH formatted counter
values, where the unpadded layout could produce invalid results. The change is
intended to make the struct layout match the native PDH structure more
reliably.