fix: avoid codex apps probing during server listing - #11
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c616de5d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -50,25 +51,6 @@ func (c *Catalog) ServerNames(ctx context.Context) ([]string, error) { | |||
| names[name] = struct{}{} | |||
There was a problem hiding this comment.
For users relying on Codex app fallback/discovery, aliases such as linear and zillow only exist after listTools feeds codexVirtualServerMap; this implementation now returns only the literal cfg.Servers keys (minus codex_apps), so list_servers becomes empty or incomplete. That regresses multiple CLI paths that consume list_servers: the root mcpx listing can incorrectly print “No MCP servers configured” (internal/cli/root.go), mcpx <alias> --help rejects valid virtual servers because it preflights against that list, and completion / mcpx shim install <alias> no longer discover those servers (internal/cli/completion_runtime.go, internal/cli/shim.go). The docs still advertise these virtual per-app servers in docs/usage.md.
Useful? React with 👍 / 👎.
…shadowing (#36) * fix: stop CWD config discovery, listing probes, and fallback command shadowing Rewrite the still-valid security/correctness fixes from stale PRs #12, #11, and #10 onto current main. Bare mcpx stays config-only, project-local .mcp.json is no longer auto-imported, and fallback merge is skipped when managed servers already exist. * fix: align fallback watch with managed config and keep named virtual servers Skip merge and source watching only when config.toml has MCPXConfig origins, not whenever cfg.Servers is non-empty. Filter reserved CLI names from fallback discovery, and resolve explicit --help / shim install targets via list_tools so Codex virtual servers still work.
|
Superseded by #36 (landed on main). Closing this stale March branch. |
1 participant
Motivation
listToolsforcodex_apps, allowing stdio transports to be spawned during merelist_servers/CLI completion and creating an execution-on-list regression.Description
Catalog.ServerNamessoServerNamesno longer calls thelistToolscallback and therefore will not trigger MCP connections forcodex_apps(internal/servercatalog/catalog.go).Catalog.Resolveremains unchanged).internal/servercatalog/catalog_test.goandinternal/daemon/daemon_tools_test.goto expect only configured servers and zerolist-toolscalls during listing, and remove an unused import in the daemon test.Testing
env -u CODEX_HOME go test ./..., and all packages passed after the changes (tests previously failed before fixes).env -u CODEX_HOME go vet ./...with no issues reported.env -u CODEX_HOME go build ./...which completed successfully.Codex Task