Skip to content

fix: mount a Dialog only once its theme is read #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulnsanand merged 1 commit into from
Sep 27, 2026
Merged

fix: mount a Dialog only once its theme is read #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/luthor/src/core/ui.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,8 @@ export function Dialog({
useLayoutEffect(() => {
if (isOpen && anchorRef.current) {
setThemeStyle(getOverlayThemeStyleFromElement(anchorRef.current));
} else if (!isOpen) {
setThemeStyle(undefined);
}
}, [isOpen]);

Expand Down Expand Up @@ -444,7 +446,10 @@ export function Dialog({
}, [isOpen, onClose]);

const anchor = <span ref={anchorRef} className="luthor-dialog-anchor" hidden />;
if (!isOpen || typeof document === "undefined") return anchor;
// Mount the portal only once the theme is read: a first paint without it had
// no background, and the theme transition then faded the panel in from
// transparent.
if (!isOpen || !themeStyle || typeof document === "undefined") return anchor;

const overlay = (
<div className="luthor-dialog-overlay luthor-dialog-overlay--portal" style={themeStyle}>
Expand Down
Loading