Launch custom code - #1152
Open
lylo wants to merge 3 commits into
Open
Conversation
Removes the feature toggle, so head and body code are available to every subscriber and the feature appears on the marketing pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the feature toggle from #1146, so head and body code are available to every subscriber rather than to flagged users only.
config/features.rb: thecustom_codeflag is gonecustom_code_editable?is inlined intocustom_code_paramsnow that it only checks the subscriptionllms.txtare unconditionaljoelfixture and removes the "without the feature flag" case, which no longer has anything to assertBehaviour change: every subscriber gets head and body code, and the feature is advertised publicly. Nothing else moves – free and trial users are still limited to Custom CSS and the footer.
Deploy note:
llms.txtand the comparison pages are page-cached and their output changes here, so this deploy needsrails cache:expire_static_pages, plus a Cloudflare purge for/.Based on #1146 – merge that first.