Update Codex runtime while preserving queued reviews and MCP sessions - #387
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 701885799c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Purpose
Update Codex without restarting ReviewMonitor or disconnecting existing MCP calls. New review requests stay in the Store queue while current reviews finish, then continue as the same jobs after app-server is replaced.
Changes
updateCodex(when:install:)SPI, supporting deferred and immediate updates. Concurrent requests join one installation operation.Testing
swift test --build-system swiftbuild --no-parallel: 1,253 tests passed.xcodebuild test, macOS arm64, signing disabled,-skipMacroValidation: 42 tests passed.main:E0323A94-F76D-4516-BA29-B429863ADE89, completed with no findings.Tests inject the installer and backend/transport; no installed Codex command or running ReviewMonitor was replaced.
Closes #384. Part of #382.