Skip to content

Keep Codex updates responsive and add update simulation - #389

Merged
lynnswap merged 3 commits into
mainfrom
codex/update-responsiveness
Oct 1, 2026
Merged

lynnswap merged 3 commits into
mainfrom
codex/update-responsiveness

Conversation

@lynnswap

@lynnswap lynnswap commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Purpose

Keep ReviewMonitor responsive while checking for Codex updates and discovering the executable for a runtime restart. Add a repeatable simulation for investigating the reported slowdown through the normal Update button and runtime lifecycle.

Changes

  • Run the complete update check, including file resolution and doctor JSON decoding, outside the main actor. Resolve the executable for each new runtime process in a detached task, then check acquisition cancellation before starting the runtime factory.
  • Present update timing choices asynchronously as a sheet when the main window is visible, allowing main-actor tasks to continue while awaiting a choice.
  • Add REVIEW_MONITOR_SIMULATE_CODEX_UPDATE=1 to the Xcode scheme as a disabled option and document its use. The simulation performs a one-second check and a ten-second installation wait using the existing subprocess runners, then stops and restarts the live Codex runtime without changing Codex or Homebrew packages.
  • Cover environment selection, simulated installation, background execution, cancellation during executable resolution, and both update timing choices in regression tests.

Testing

  • swift test --build-system swiftbuild --no-parallel: all 1,256 package tests passed.
  • xcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO -skipMacroValidation: all 48 app tests passed. Macro validation uses the same opt-out as repository CI and local builds.
  • git diff --check: passed.
  • codex-review against main: completed with no findings using pinned base 15bc72add2c570c65bf800cec28674dabe092765 (job F6A1BDF1-6604-47ED-9050-F6BB07F4E734).

Actual Homebrew installation and an end-to-end reproduction of the reported severe slowdown remain unverified.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T23:40:33.325792Z 5a09b9f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78161e7634

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexReviewHost/LiveCodexReviewStoreBackend.swift

@lynnswap lynnswap left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 5a09b9f246

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap
lynnswap merged commit a4fb979 into main Oct 1, 2026
5 checks passed
@lynnswap
lynnswap deleted the codex/update-responsiveness branch October 1, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant