Repository navigation
Support standalone Codex updates and show update progress - #391
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #390
Purpose
ReviewMonitor now checks and updates standalone Codex installations using the selected CLI's installation home, instead of rejecting them or passing the isolated review home. The sidebar Update button shows a spinner and the current stage while Codex stops, installs, and restarts.
Changes
Review focus
Installation targeting for standalone and Homebrew CLIs, stable-launcher handling, and preservation of review deferral, queued requests, and runtime restart behavior.
Screenshots
No screenshot attached; UI preview rendering remains unverified. Automated UI tests cover toolbar progress presentation and nonzero layout size.
Testing
swift test --build-system swiftbuild --no-parallel: all 1,256 package tests passed.xcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' -skipMacroValidation CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO: all app tests passed. Macro validation uses the same opt-out as repository CI.git diff --check: passed.codex-reviewof the final diff: completed with no findings (job80224CD6-D33D-4025-874B-76B12A08EB65).Installation targeting and launcher refresh were verified with fixture CLI processes; an actual Codex package update was not performed.