Skip to content

Build local ReviewMonitor updates as timestamped DMGs - #392

Merged
lynnswap merged 3 commits into
mainfrom
codex/local-dmg-builds
Oct 3, 2026
Merged

lynnswap merged 3 commits into
mainfrom
codex/local-dmg-builds

Conversation

@lynnswap

@lynnswap lynnswap commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Purpose

The local installer requires quitting the app before building and removing an existing /Applications copy, extending update downtime through the build. Create a validated DMG while reviews continue, then replace the app through Finder when ready.

Changes

  • Replace the installer with python3 scripts/build_review_monitor.py (Python 3.10+), which creates dist/CodexReviewMonitor_yymmdd_hhmm.dmg.
  • Retain build caches, prepare the pinned DMG tools, and reuse the existing packaging and validation.
  • Publish only the verified DMG in one final rename. Keep the signed app in temporary packaging storage, leaving existing dist/arm64 release artifacts untouched and preserving the previous DMG if publication fails.
  • Preserve resource metadata when DITTONORSRC is set, and update the README and CI coverage for the build workflow.

Testing

  • All 11 local build tests passed with RUN_LOCAL_BUILD_INTEGRATION=1, including a real Release build, ad-hoc signing, mounted DMG verification, resource metadata preservation, and failed-publication regressions. Custom signing identities were tested with mocked commands.
  • All 10 release packaging tests passed; the release packaging code is unchanged.
  • Ran the CLI while the installed app was running, including with DITTONORSRC=1; the installed app and running process remained unchanged.
  • git diff --check and actionlint passed with the existing unknown xcode-27 label diagnostic excluded. The label is documented in actions/runner-images#14404.
  • Codex review against the pinned main commit completed with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T07:34:40.353365Z 7d18c2d Manual request
🔒 Security Review ✅ Completed 2026-10-03T07:20:18.412032Z f5a05b6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5a05b616b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/build_review_monitor.py

@lynnswap lynnswap left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 7d18c2de0a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap
lynnswap merged commit 0f3f7a1 into main Oct 3, 2026
5 checks passed
@lynnswap
lynnswap deleted the codex/local-dmg-builds branch October 3, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant