Skip to content

Add workspace sorting by latest accepted job - #393

Merged
lynnswap merged 2 commits into
mainfrom
codex/workspace-latest-job-sort
Oct 3, 2026
Merged

lynnswap merged 2 commits into
mainfrom
codex/workspace-latest-job-sort

Conversation

@lynnswap

@lynnswap lynnswap commented Oct 3, 2026

Copy link
Copy Markdown
Owner

Purpose

ReviewMonitor currently supports only manual workspace ordering. Add Latest Job First so accepting a new job moves its workspace to the top, including when the job is queued.

Changes

  • Add Manual and Latest Job First under Workspace Order in the existing filter menu, and persist the selected mode across launches.
  • Sort workspace sections by the latest job acceptance time. Linked worktrees move together as a repository group, and filtered-out jobs still contribute to the order.
  • Disable workspace drag and drop in automatic mode, preserve the saved manual order, and restore it when switching back to Manual. Job reordering and job filters remain independent.
  • Pass the existing persisted acceptedAt value to live and restored jobs. Preserve selection and expansion state when sections move, and use manual order for equal timestamps or empty workspaces.

Testing

Passed package and ReviewMonitor app tests:

swift test --build-system swiftbuild --no-parallel
xcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO -skipMacroValidation

The app test uses the same -skipMacroValidation flag as repository CI. Added coverage for queued acceptance, linked worktrees and hidden jobs, drag and drop, manual order restoration, selection and expansion retention, and preference persistence. Codex review completed with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T08:33:23.739330Z cbbb991 Manual request
🔒 Security Review ✅ Completed 2026-10-03T08:19:07.232796Z 2c02e1c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c02e1ce1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap lynnswap left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: cbbb9915ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap
lynnswap merged commit b075b3b into main Oct 3, 2026
5 checks passed
@lynnswap
lynnswap deleted the codex/workspace-latest-job-sort branch October 3, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant