完善了optimizer尚未完成的部分#158
Open
daxiami233 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
author: daxiami233
Name: 夏昌炜
实现了ApplyPushDownRule中Remove useless Apply功能。包括:
对DataFrame.scala中schema和records进行懒加载,避免不必要的计算。
author: ytding1999
Name: 丁煜桐
负责部分:实现了optimizer/RemoveApplyRule.scala中的FromArgument合并功能
发现了case Seq(FromArgument(variableName)) => apply.right的问题:
使用 get 可能会导致空指针异常;只处理了右子树只有单个 FromArgument 的情况;没有正确处理右子树中的其他操作
优化流程:
先检查是否可以应用 Unwind 优化,如果不能,则检查是否可以应用 FromArgument 优化:
检查右子树的所有叶子节点是否都是 FromArgument;如果是,则重构查询计划,移除 FromArgument 并保留其他操作。