Overhaul Rank recalculation#308
Open
AroPix wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I tested it with both manualmaploading being disabled and it being enabled. |
Contributor
Author
|
I'ts been on all my servers (including Lucky Lol) since i opened the PR, and i haven't encountered any issues with it yet. |
AroPix
force-pushed
the
fix/rank-recalculation
branch
from
62e04f3 to
267f5b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make sure that it can handle race conditions properly, as example multiple people removing/adding maps at the same time.