Skip to content

feat: add upgradeable contracts#44

Merged
PierrickGT merged 1 commit intomainfrom
feat/upgradeable-contracts
May 27, 2025
Merged

feat: add upgradeable contracts#44
PierrickGT merged 1 commit intomainfrom
feat/upgradeable-contracts

Conversation

@PierrickGT
Copy link
Member

No description provided.

@PierrickGT PierrickGT requested a review from toninorair May 26, 2025 21:58
@github-actions
Copy link

Changes to gas cost

Generated at commit: 8993496bbc54798c258235db4969d047b0855b2f, compared to commit: d7ee4580de0ebfdb379491a8328647cc2c6677d0

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ERC20ExtendedHarness approve
transfer
-59 ✅
-84 ✅
-0.13%
-0.27%
ERC20ExtendedHandler approve
mint
-110 ✅
-117 ✅
-0.21%
-0.16%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ERC20ExtendedHarness 2,825,346 (+12) approve
burn
mint
permit
receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes)
receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes32,bytes32)
receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,uint8,bytes32,bytes32)
transfer
transferFrom
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes)
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes32,bytes32)
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,uint8,bytes32,bytes32)
26,852 (-12)
24,522 (+12)
29,060 (0)
24,983 (-12)
63,860 (0)
62,904 (0)
32,009 (0)
24,499 (-12)
25,361 (-12)
63,706 (0)
62,882 (0)
31,918 (0)
-0.04%
+0.05%
0.00%
-0.05%
0.00%
0.00%
0.00%
-0.05%
-0.05%
0.00%
0.00%
0.00%
46,588 (-59)
29,383 (+7)
64,917 (+16)
62,608 (0)
81,914 (+3)
80,958 (+3)
78,707 (+3)
31,406 (-84)
34,071 (+27)
81,759 (+2)
80,935 (+2)
78,748 (+1)
-0.13%
+0.02%
+0.02%
0.00%
+0.00%
+0.00%
+0.00%
-0.27%
+0.08%
+0.00%
+0.00%
+0.00%
46,860 (+12)
29,310 (0)
69,112 (0)
77,537 (0)
82,116 (0)
81,160 (0)
81,430 (0)
29,589 (0)
32,789 (+204)
81,962 (0)
81,138 (0)
81,290 (0)
+0.03%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
+0.63%
0.00%
0.00%
0.00%
47,148 (0)
35,282 (0)
69,472 (0)
78,539 (0)
82,500 (0)
81,544 (0)
81,814 (0)
47,873 (0)
54,733 (+860)
82,346 (0)
81,522 (0)
81,682 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
+1.60%
0.00%
0.00%
0.00%
2,255 (-57)
1,842 (+15)
4,878 (-25)
1,542 (0)
257 (0)
257 (0)
271 (0)
1,814 (+77)
2,051 (-12)
257 (0)
257 (0)
270 (0)
ERC20ExtendedHandler 1,370,312 (0) approve
burn
mint
transfer
transferFrom
32,893 (-12)
48,291 (0)
679 (0)
780 (0)
886 (0)
-0.04%
0.00%
0.00%
0.00%
0.00%
52,588 (-110)
50,532 (+12)
74,256 (-117)
63,602 (-53)
63,849 (-31)
-0.21%
+0.02%
-0.16%
-0.08%
-0.05%
52,889 (0)
50,619 (0)
69,251 (+12)
63,796 (0)
64,256 (+12)
0.00%
0.00%
+0.02%
0.00%
+0.02%
53,189 (0)
59,187 (+8,372)
103,691 (0)
63,992 (0)
137,674 (+73,222)
0.00%
+16.48%
0.00%
0.00%
+113.61%
1,225 (-58)
1,329 (+15)
1,284 (-25)
1,302 (+78)
1,285 (-10)
SignatureCheckerHarness 985,574 (+12) isValidECDSASignature(address,bytes32,bytes)
isValidSignature
validateECDSASignature(address,bytes32,bytes)
validateECDSASignature(address,bytes32,bytes32,bytes32)
2,236 (0)
5,743 (0)
2,100 (0)
1,641 (0)
0.00%
0.00%
0.00%
0.00%
6,063 (-1)
6,201 (-1)
5,927 (-1)
5,490 (-1)
-0.02%
-0.02%
-0.02%
-0.02%
6,084 (0)
6,170 (0)
5,948 (0)
5,489 (0)
0.00%
0.00%
0.00%
0.00%
6,115 (0)
10,448 (0)
5,979 (0)
5,520 (0)
0.00%
0.00%
0.00%
0.00%
262 (0)
532 (0)
262 (0)
518 (0)
VoidDeployer 128,023 (-12)
AccountWithFallback 68,573 (+12)
AccountWithFunctionReturningInvalidData 208,412 (-12)
AccountWithoutFallback 66,842 (-12)
Bytes32StringHarness 405,806 (+12)

@github-actions
Copy link

LCOV of commit ad4e511 during Forge Coverage #136

Summary coverage rate:
  lines......: 93.3% (402 of 431 lines)
  functions..: 93.2% (110 of 118 functions)
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  src/ERC20ExtendedUpgradeable.sol   |31.7%     41| 0.0%    13|    -      0
  src/ERC3009Upgradeable.sol         |22.8%     57| 0.0%    13|    -      0
  src/ERC712ExtendedUpgradeable.sol  |25.6%     39| 0.0%    10|    -      0
  src/StatefulERC712Upgradeable.sol  |50.0%      6| 0.0%     3|    -      0

Copy link
Collaborator

@toninorair toninorair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PierrickGT PierrickGT merged commit 854a006 into main May 27, 2025
2 checks passed
@PierrickGT PierrickGT deleted the feat/upgradeable-contracts branch May 27, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants