Extend type converter to avoid duplication of file in different projects#49
Open
toninorair wants to merge 1 commit intomainfrom
Open
Extend type converter to avoid duplication of file in different projects#49toninorair wants to merge 1 commit intomainfrom
toninorair wants to merge 1 commit intomainfrom
Conversation
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
LCOV of commit
|
PierrickGT
requested changes
Dec 15, 2025
| /// @notice Converts a uint256 to uint16, reverting if the value overflows. | ||
| /// @param value The uint256 value to convert. | ||
| /// @return The uint16 representation of the value. | ||
| function toUint16(uint256 value) internal pure returns (uint16) { |
Member
There was a problem hiding this comment.
We should add unit tests for these new functions.
Member
There was a problem hiding this comment.
I didn't notice it before but these functions are similar to the ones we have in UintMath.
Line 40 in e54273e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the type converter to eliminate copy-paste in the portal-v2 project.
Additionally, review whether most of its methods are still needed, given the previously introduced
UintMath.