Skip to content

ci: harden exec-mode test against macOS connection races #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m1ngsama merged 1 commit into from
Jun 29, 2026
Merged

ci: harden exec-mode test against macOS connection races #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/test_exec_mode.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,20 @@ if [ ! -f "$BIN" ]; then
exit 1
fi

SSH_OPTS="-n -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o BatchMode=yes -p $PORT"
# ConnectionAttempts/ConnectTimeout make each exec connection resilient to the
# transient "connection closed during identification" races seen on slow CI
# runners (notably macOS).
SSH_OPTS="-n -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o BatchMode=yes -o ConnectionAttempts=3 -o ConnectTimeout=15 -p $PORT"
TNTCTL_OPTS="--host-key-checking no --known-hosts /dev/null"

echo "=== TNT Exec Mode Tests ==="

TNT_LANG=zh TNT_RATE_LIMIT=0 $BIN -p "$PORT" -d "$STATE_DIR" >"${STATE_DIR}/server.log" 2>&1 &
# This suite opens many short-lived exec connections in quick succession. On
# macOS the closed sockets linger, so the default per-IP concurrency cap (5)
# can be transiently exceeded and a connection refused mid-suite. Raise the
# caps well above the number of in-flight connections this test can produce.
TNT_LANG=zh TNT_RATE_LIMIT=0 TNT_MAX_CONN_PER_IP=256 TNT_MAX_CONNECTIONS=256 \
$BIN -p "$PORT" -d "$STATE_DIR" >"${STATE_DIR}/server.log" 2>&1 &
SERVER_PID=$!

HEALTH_OUTPUT=""
Expand Down
Loading