ci: harden remaining integration tests against connection races#65
Merged
Conversation
PR #63 fixed test_exec_mode.sh; apply the same hardening to the other integration tests that launch a server and open SSH connections in quick succession (test_basic, test_module_runtime, test_anonymous_access, test_interactive_input, test_mute_joins_view, test_empty_view): - launch the test server with TNT_MAX_CONN_PER_IP=256 TNT_MAX_CONNECTIONS=256 so rapid localhost connections never transiently exceed the default per-IP cap (5) on slow CI runners (the macOS/loaded-ubuntu flake root cause), and - add ssh ConnectionAttempts=3 / ConnectTimeout=15 so a dropped identification handshake is retried rather than failing an assertion. test_user_lifecycle.sh already sets a high per-IP cap; test_tntctl_cli.sh uses a fake ssh (no real server); test_connection_limits.sh intentionally exercises the caps -- all left unchanged. Also bump the version in the MODULE_PROTOCOL.md handshake example to 1.2.0. Verified: integration + anonymous-access suites pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #63. The integration suite intermittently goes red on loaded/macOS CI runners (seen on PR #62 and PR #64) because tests open many short-lived SSH connections in quick succession and transiently exceed the server's default per-IP concurrency cap (
TNT_DEFAULT_MAX_CONN_PER_IP = 5). #63 fixed onlytest_exec_mode.sh; the same race affects the rest.Fix
Apply the #63 hardening to the other integration tests that launch a server and connect over SSH:
test_basic.sh,test_module_runtime.sh,test_anonymous_access.sh,test_interactive_input.sh,test_mute_joins_view.sh,test_empty_view.shEach now:
TNT_MAX_CONN_PER_IP=256 TNT_MAX_CONNECTIONS=256(root cause), and-o ConnectionAttempts=3 -o ConnectTimeout=15to its ssh options (SSH-layer resilience).Intentionally unchanged
test_user_lifecycle.sh— already sets--max-conn-per-ip 32.test_tntctl_cli.sh— uses a fake ssh in PATH (no real server).test_connection_limits.sh— deliberately exercises the caps.Also bumps the version in the
docs/MODULE_PROTOCOL.mdhandshake example to 1.2.0.Verification
No product code touched.
make integration-testandmake anonymous-access-testpass locally (exit 0). This should eliminate the recurring re-run-to-green need.