New features, enhancements and refactoring #25
Open
itaymesh wants to merge 23 commits intom2-boilerplate:masterfrom
Open
New features, enhancements and refactoring #25itaymesh wants to merge 23 commits intom2-boilerplate:masterfrom
itaymesh wants to merge 23 commits intom2-boilerplate:masterfrom
Conversation
* Updated: logic of base Plugin; * Implemented: validation on UserAgent value;
* Implemented: workaround to provide processing url with random query-string param-value;
…n-generartion' into feature/skip-critical-css-flag-on-generartion
…n-generartion Feature/skip critical css flag on generartion
…n-generartion CLI command info output rephrasing
* Implemented: logic to skip Critical CSS <link> nodes manipulation, in case crit-css style-node does not exist or is empty; * Re-factored: logic of AsyncCssPlugin;
* Implemented: logic to get and handle specified Store Ids to limit processing Stores;
superdav42
reviewed
Jun 13, 2024
Comment on lines
+103
to
+104
| // TODO: decide whether cache flushing is really required. temporally commented. | ||
| //$this->cacheManager->flush($this->cacheManager->getAvailableTypes()); |
There was a problem hiding this comment.
I'm pretty sure we only need to flush the full page cache. It would be much better
|
Any reason these weren't integrated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.