fix: merge clip outputs before saving batdetect2 format#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a regression in
batdetect2 process directorywhen saving predictions in thebatdetect2output format.When inference produced multiple clip-level predictions for the same recording, each clip was being saved to the same output filename derived from the recording name. That meant later clips overwrote earlier ones, so only detections from the last clip appeared in the final saved file.
This change merges clip-level predictions belonging to the same recording into a single recording-level
ClipDetectionsobject before formatting and saving in thebatdetect2format.Thanks to @Jeff37 for pointing this out!
Additional Note
This branch also includes a small plotting update that was added while diagnosing the issue and is worth keeping.
Testing
uv run pytest tests/test_inference/test_batch.py tests/test_cli/test_process.py