breaking: EventInfo member pointers

[luketpickering]

EventInfo data members were mostly pointers. It is clear that for reconstructed or some true quantities, using pointers to experiment-subclass owned memory allows the subclasses to make systematic variations without negotiation with the base class, but the data members in EventInfo should never change.

Changed the following data members from pointers to instances of the relevant primitive type: Target, Mode, nupdg, nupdgUnosc, enu_true, coszenith_true

• also rename rw_etru -> enu_true and rw_truecz -> coszenith_true for clarity
• also changed the type of Mode from double (?) to int
• also tidy some odd iterator indirection syntax

Action Required:

• Experiment SampleHandlerFD subclasses will need to update their SetupFDMC implementation to set values and not pointers.

---

• I have read and followed the contributing guidelines.

[github-actions]

Hi @luketpickering, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

Use this action on your projects. Use jokes on issues instead.