Skip to content

Conversation

@macrat
Copy link
Owner

@macrat macrat commented Oct 23, 2023

No description provided.

macrat added 29 commits January 3, 2023 16:09
The port 22 has used by GitHub Actions itself and unavailable, so I had
to avoid this port.
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 91.56142% with 147 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.89%. Comparing base (00aeac3) to head (e4509a0).

Files with missing lines Patch % Lines
internal/query/tokenizer.go 88.75% 27 Missing ⚠️
internal/query/valuematcher.go 89.45% 26 Missing and 1 partial ⚠️
internal/scheme/ssh.go 92.10% 12 Missing and 6 partials ⚠️
internal/scheme/file.go 81.42% 11 Missing and 2 partials ⚠️
internal/scheme/source.go 84.41% 8 Missing and 4 partials ⚠️
internal/scheme/exec.go 92.66% 7 Missing and 4 partials ⚠️
cmd/ayd/schedule.go 84.48% 6 Missing and 3 partials ⚠️
internal/query/query.go 96.86% 6 Missing and 2 partials ⚠️
internal/store/incident.go 71.42% 4 Missing and 2 partials ⚠️
internal/query/operator.go 88.88% 4 Missing ⚠️
... and 5 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   86.99%   87.89%   +0.89%     
==========================================
  Files          66       74       +8     
  Lines        4992     6466    +1474     
==========================================
+ Hits         4343     5683    +1340     
- Misses        534      644     +110     
- Partials      115      139      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

macrat and others added 11 commits April 28, 2025 12:51
Found and fix using OpenAI Codex.
When searchLog() returns an error in newFileScanner(), the opened file
handle was not being closed, leading to resource leaks. Added explicit
f.Close() call in the error path to ensure proper cleanup.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Added explicit error handling for conn.Quit() in FTP login failure path.
The error is intentionally ignored with _ assignment as connection cleanup
errors during login failure are not critical and should not mask the
original login error.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Added nil check for p.stop before calling it in Stop() method to prevent
potential panic if Stop() is called multiple times.

Also added comprehensive tests to verify the fix works correctly.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@macrat macrat requested a review from Copilot September 2, 2025 12:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the project version to 0.17 and introduces extensive support for SSH/SFTP protocols across various components.

Key changes include:

  • SSH/SFTP Support: Adds comprehensive SSH and SFTP scheme implementations for probing, alerting, and source operations
  • Enhanced Error Handling: Improves incident message comparison logic to handle port number variations
  • Testing Infrastructure: Adds Docker-based test containers and comprehensive test coverage for new protocols
  • Query System Improvements: Introduces a new query parsing system with value matchers and tokenizers

Reviewed Changes

Copilot reviewed 84 out of 85 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
testdata/docker-compose.yml Defines test containers for FTP, SSH, and management services
testdata/sshd/* SSH server Docker configuration and test scripts
testdata/manager/* Test data management service for container tests
internal/scheme/ssh*.go Core SSH protocol implementation for connections and probing
internal/scheme/sftp*.go SFTP protocol implementation for file operations
internal/scheme/exec.go Refactored exec scheme with SSH support
internal/scheme/shell/* Shell command escaping utilities
internal/store/incident.go Enhanced incident message comparison logic
internal/query/* New query parsing system with tokenizers and matchers
lib-ayd/time.go Extended time parsing with additional formats

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@macrat macrat merged commit 254a22f into main Sep 2, 2025
7 checks passed
@macrat macrat deleted the v0.17 branch September 2, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants