-
Notifications
You must be signed in to change notification settings - Fork 2
version 0.17 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 0.17 #19
Conversation
The port 22 has used by GitHub Actions itself and unavailable, so I had to avoid this port.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 86.99% 87.89% +0.89%
==========================================
Files 66 74 +8
Lines 4992 6466 +1474
==========================================
+ Hits 4343 5683 +1340
- Misses 534 644 +110
- Partials 115 139 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Found and fix using OpenAI Codex.
When searchLog() returns an error in newFileScanner(), the opened file handle was not being closed, leading to resource leaks. Added explicit f.Close() call in the error path to ensure proper cleanup. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added explicit error handling for conn.Quit() in FTP login failure path. The error is intentionally ignored with _ assignment as connection cleanup errors during login failure are not critical and should not mask the original login error. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added nil check for p.stop before calling it in Stop() method to prevent potential panic if Stop() is called multiple times. Also added comprehensive tests to verify the fix works correctly. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Found and fix using OpenAI Codex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the project version to 0.17 and introduces extensive support for SSH/SFTP protocols across various components.
Key changes include:
- SSH/SFTP Support: Adds comprehensive SSH and SFTP scheme implementations for probing, alerting, and source operations
- Enhanced Error Handling: Improves incident message comparison logic to handle port number variations
- Testing Infrastructure: Adds Docker-based test containers and comprehensive test coverage for new protocols
- Query System Improvements: Introduces a new query parsing system with value matchers and tokenizers
Reviewed Changes
Copilot reviewed 84 out of 85 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testdata/docker-compose.yml | Defines test containers for FTP, SSH, and management services |
| testdata/sshd/* | SSH server Docker configuration and test scripts |
| testdata/manager/* | Test data management service for container tests |
| internal/scheme/ssh*.go | Core SSH protocol implementation for connections and probing |
| internal/scheme/sftp*.go | SFTP protocol implementation for file operations |
| internal/scheme/exec.go | Refactored exec scheme with SSH support |
| internal/scheme/shell/* | Shell command escaping utilities |
| internal/store/incident.go | Enhanced incident message comparison logic |
| internal/query/* | New query parsing system with tokenizers and matchers |
| lib-ayd/time.go | Extended time parsing with additional formats |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.