Skip to content

Conversation

@macrat
Copy link
Owner

@macrat macrat commented May 17, 2025

Summary

  • move isTerminal/isCygwinTerminal helpers above ConvCommand.Run
  • adjust xlsx condition to use them
  • consolidate TTY tests into conv_internal_test.go and cover all format/terminal combinations

Testing

  • go test ./cmd/ayd -run TestConvCommand_TTYWarning -count=1
  • go test ./cmd/ayd (fails: TestAydCommand_Run_permissionDenied)

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (a64dc74) to head (aec323c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.17      #24      +/-   ##
==========================================
+ Coverage   87.80%   87.89%   +0.08%     
==========================================
  Files          72       74       +2     
  Lines        6429     6466      +37     
==========================================
+ Hits         5645     5683      +38     
+ Misses        645      644       -1     
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@macrat macrat marked this pull request as ready for review July 14, 2025 06:45
@macrat macrat merged commit 4d8c1cf into v0.17 Jul 14, 2025
7 checks passed
@macrat macrat deleted the codex/wrap-terminal-checks-in-parentheses-and-add-test branch July 14, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants