-
Notifications
You must be signed in to change notification settings - Fork 3
fix(email): Email scroll jumping, suspense issues, and refactor #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dev-rb
wants to merge
39
commits into
main
Choose a base branch
from
rahul/m-5455-email-thread-scroll-jump
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mail-thread-scroll-jump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves an issue where on initial load of an email thread, the container would scroll to the top of the thread after a second or two.
This was caused by the
EmailDebouncedReadMarkerperforming a mutation to mark the email as seen and that mutation invalidating the query of the email thread and triggering suspense. Adding a check for whether the email is actually unread prevents the unnecessary mutation for already read emails.However, there were more issues with Suspense because of the places where query data was being read so this PR also refactors the implementation for email threads and cleans up some logic. In addition, email threads are now being displayed in reverse order — using
flex-direction: 'column-reverse'on the container andtoReversedon the data list — like channels so that the scroll position always start from the bottom and we can avoid some unnecessary jumping.Other fixes/additions:
MarkdownTextareacallingprops.onChangetoo eagerly when nothing had changed except the initial value being setuseThreadQueryto make it more flexible and overloads the function to fix the typing of the return resultScreenshots, GIFs, and Videos
First email in thread showing full html bug:
