fix(ws): resolve auth deadlock and binary frame handling#3
Merged
Conversation
… client - Start receive loop before _authenticate() so auth responses are processed instead of deadlocking - Skip binary WebSocket frames in _receive_loop and pass text messages directly without str() wrapping - Add 15 unit tests covering event emitter, auth flow, binary frame skipping, disconnect, and error paths
…on bug - Replace npm/package.json references with pytest/pyproject.toml across all Git Flow command files (hotfix, release, finish, flow-status) - Fix $() command substitution in !-backtick lines that broke command execution - Update .gitignore to exclude underscore-prefixed notebooks - Update IDE configuration
- E731: replace lambda assignment with def - F841: remove unused variable original_authenticate - SIM117: combine nested with statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_authenticate()to prevent deadlock where auth responses are never processed_receive_loopand pass text messages directly withoutstr()wrapping.claude/commands/templates from npm/Node.js to Python tooling (pytest, pyproject.toml)Test plan
pytest tests/unit/test_ws_client.py— 15/15)