Skip to content

Conversation

@mad-sol-dev
Copy link
Owner

Summary

  • add GHIDRA_BRIDGE_PROGRAM_AUTOOPEN gating to select_program, locking selections per switch policy and propagating cautious warnings
  • expose the Ghidra client open_program endpoint to auto-open validated project files
  • refresh program selection tests to cover locking behavior and auto-open flows

Testing

  • pytest bridge/tests/unit/test_program_selection_tools.py
  • pytest bridge/tests/contract/test_program_selection.py

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +603 to +607
requester = EndpointRequester(
self,
"GET",
key="OPEN_PROGRAM",
params=params,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Auto-open call blocked by whitelist

The new auto-open flow invokes EndpointRequester(..., key="OPEN_PROGRAM", ...), but DEFAULT_WHITELIST does not contain an OPEN_PROGRAM entry, so _request_lines rejects the request as non-whitelisted. When GHIDRA_BRIDGE_PROGRAM_AUTOOPEN is enabled every auto-open call will therefore return None, and _maybe_autoopen_program will always emit the failure warning instead of actually opening the program.

Useful? React with 👍 / 👎.

@mad-sol-dev mad-sol-dev merged commit b3d2381 into main Nov 25, 2025
5 checks passed
@mad-sol-dev mad-sol-dev deleted the codex/add-mcp-route-for-domain-file-resolution branch November 25, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants