fix: update sequence counter implementation in ack_hdr#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted change to the sequence counter logic used when constructing the
ack_hdrheader in theRuntimeclass. The update replaces the previous use of an external sequence generator with a local sequence counter.Runtimeclass (include/sero/runtime.hpp), the assignment toack_hdr.sequence_counternow uses the localsd_seq_++counter instead of callinge2e_.next_sequence(). This ensures that the sequence counter for SD subscribe acknowledgments is managed locally within the runtime, rather than relying on the external E2E sequence generator.