Fix unchecked Minizip extra-field lengths - #1314
Open
atharvmantri wants to merge 2 commits into
Open
atharvmantri wants to merge 2 commits into
atharvmantri wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unchecked Minizip extra-field lengths in
zipRemoveExtraInfoBlock().The function read a 16-bit extra-field length and used it for pointer advancement and
memcpy()without checking it against the remaining caller-provided buffer. A malformed block could therefore cause an out-of-bounds read/write. This change:ZIP_PARAMERRORbefore modifying the caller's buffer when validation fails; andThis addresses #1276.
Validation performed on Windows with native MinGW/CMake:
cmake --build build-pr1314-mingw --parallel 2passed, including the Minizip library, CLI targets, and the new regression test.git diff --checkpasses.The regression test checks both truncated headers and declared lengths that exceed the remaining buffer, verifies
ZIP_PARAMERROR, confirms the caller buffer and length remain unchanged on rejection, and confirms a valid block is still removed. Local build directories are evidence only and are not part of the source change.