Fix missing NUL termination for truncated filenames - #1315
Open
atharvmantri wants to merge 2 commits into
Open
atharvmantri wants to merge 2 commits into
atharvmantri wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminate truncated Minizip filenames returned by
unzGetCurrentFileInfo().When the ZIP entry filename is at least as long as the caller's output buffer, the existing code reads the full buffer but does not write a terminating NUL. A later
unzLocateFile()call can pass that buffer tostrlen(), causing an out-of-bounds read. This change reserves one byte for the terminator whenever a nonzero output buffer is supplied and keeps the read length consistent with that reservation.This addresses #1299.
Validation performed on Windows with native MinGW/CMake:
cmake --build build-pr1315 --parallel 2passed, including the Minizip library, CLI targets, and the new regression test.git diff --checkpasses.The regression test links the static Minizip target so it runs without relying on a platform-specific shared-DLL search path. The build directory is local evidence only and is not part of the source change.