Improve BLE device resolution and WalkingPad GATT locking#123
Open
Ceiku wants to merge 1 commit into
Open
Conversation
Use async_scanner_devices_by_address when the merged BLE handle is missing, refresh the BLEDevice before connect, fix per-call asyncio.Lock misuse, and align Bluetooth config flow unique_id with format_mac. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BLEDeviceviaasync_ble_device_from_address, with a fallback toasync_scanner_devices_by_address(strongest RSSI) when the merged device is missing—common with sparse advertisements or Bluetooth proxies.asyncio.Lockfor connect, disconnect, and all GATT commands; the previous_begin_cmd()returned a new lock each time, so operations were not actually serialised.BLEDevicefrom Home Assistant before each connect so routing stays current.device_registry.format_macforunique_idin the Bluetoothasync_step_devicepath so it matchesasync_step_bluetooth.Test plan
Made with Cursor