fix: prevent memory leak and CPU overhead in thumbnail strip generato…#1588
Open
Bhavy12-cell wants to merge 1 commit into
Open
fix: prevent memory leak and CPU overhead in thumbnail strip generato…#1588Bhavy12-cell wants to merge 1 commit into
Bhavy12-cell wants to merge 1 commit into
Conversation
|
@Bhavy12-cell is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Bhavy12-cell!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Bhavy12-cellBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1500
Root Cause
The thumbnail strip generator had these issues:
seek iteration instead of once per run
runs continued seeking after a new file was uploaded or component
unmounted, wasting CPU
Fix
src/hooks/useThumbnailStrip.ts(new)destroyed in the useEffect cleanup function
runIdRefincrements on every new file — stale runs checkrunIdRef.current !== runIdand bail out immediatelyblobUrlsReftracks every blob URL emitted — all are revokedon cleanup even if run was cancelled mid-way
callback, inside toBlob callback
src/components/ThumbnailStrip.tsx(new)src/components/VideoEditor.tsx(modified)Memory Leak Prevention
Files Changed
src/hooks/useThumbnailStrip.ts— new hook with proper cleanupsrc/components/ThumbnailStrip.tsx— new UI componentsrc/components/VideoEditor.tsx— added ThumbnailStripChecklist