Skip to content

fix: prevent infinite export when looping background music#1590

Open
Saylee12R wants to merge 1 commit into
magic-peach:mainfrom
Saylee12R:fix/export-shortest-audio
Open

fix: prevent infinite export when looping background music#1590
Saylee12R wants to merge 1 commit into
magic-peach:mainfrom
Saylee12R:fix/export-shortest-audio

Conversation

@Saylee12R

Copy link
Copy Markdown

Description

Added FFmpeg -shortest flag when a background music track is present.

This ensures exports terminate when the video stream ends, preventing excessively long or potentially infinite exports when:

  • the source video has no audio track
  • loop music is enabled
  • the background music duration exceeds the video duration

Related Issue

Fixes #1493

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: Saylee12R
  • Contribution level: Beginner

Screen Recording

N/A (logic-only bug fix, no UI changes)

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • No console.log statements left in
  • This PR is related to a valid issue

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

@Saylee12R is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Saylee12R!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @Saylee12R

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor labels Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Export Can Hang Indefinitely When Video Has No Audio and Background Music Is Looped

1 participant