Skip to content

fix: batch - onboarding viewport, tooltip overflow, share button colors #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −18
Open

fix: batch - onboarding viewport, tooltip overflow, share button colors #1598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default function Footer() {
const [isExpanded, setIsExpanded] = useState(false);

return (
<footer className="w-full border-t border-[var(--border)] bg-[var(--bg)] text-[var(--text)] px-6 py-16 mt-20 transition-colors duration-300">
<footer className="w-full border-t border-[var(--border)] bg-[var(--bg)] text-[var(--text)] px-6 py-16 mt-20 transition-colors duration-300 overflow-x-hidden">
<div className="max-w-7xl mx-auto grid grid-cols-1 md:grid-cols-12 gap-12 md:gap-8">

{/* Brand Section */}
Expand Down
2 changes: 1 addition & 1 deletion src/components/NativeShareButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export function NativeShareButton({
disabled={isSharing}
type="button"
aria-label="Share video"
className={`inline-flex items-center justify-center px-4 py-2 text-sm font-medium text-white transition-colors duration-200 bg-blue-600 rounded-md shadow-sm hover:bg-blue-700 focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-2 focus:ring-offset-gray-900 disabled:opacity-50 disabled:cursor-not-allowed ${className}`}
className={`inline-flex items-center justify-center px-4 py-2 text-sm font-medium text-white transition-colors duration-200 bg-[var(--accent)] rounded-md shadow-sm hover:bg-[var(--accent-hover)] focus:outline-none focus:ring-2 focus:ring-[var(--accent)] focus:ring-offset-2 disabled:opacity-50 disabled:cursor-not-allowed ${className}`}
>
<svg
className="w-5 h-5 mr-2 -ml-1"
Expand Down
40 changes: 24 additions & 16 deletions src/components/OnboardingTour.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,36 +63,44 @@ function getTooltipStyle(
const tw = tooltip?.offsetWidth ?? 320;
const th = tooltip?.offsetHeight ?? 140;

const vw = typeof window !== "undefined" ? window.innerWidth : 0;
const vh = typeof window !== "undefined" ? window.innerHeight : 0;

const sr = {
top: rect.top - PADDING,
left: rect.left - PADDING,
width: rect.width + PADDING * 2,
height: rect.height + PADDING * 2,
};

let top = 0;
let left = 0;

switch (position) {
case "top":
return {
top: sr.top - th - TOOLTIP_OFFSET,
left: sr.left + sr.width / 2 - tw / 2,
};
top = sr.top - th - TOOLTIP_OFFSET;
left = sr.left + sr.width / 2 - tw / 2;
break;
case "left":
return {
top: sr.top + sr.height / 2 - th / 2,
left: sr.left - tw - TOOLTIP_OFFSET,
};
top = sr.top + sr.height / 2 - th / 2;
left = sr.left - tw - TOOLTIP_OFFSET;
break;
case "right":
return {
top: sr.top + sr.height / 2 - th / 2,
left: sr.left + sr.width + TOOLTIP_OFFSET,
};
top = sr.top + sr.height / 2 - th / 2;
left = sr.left + sr.width + TOOLTIP_OFFSET;
break;
case "bottom":
default:
return {
top: sr.top + sr.height + TOOLTIP_OFFSET,
left: sr.left + sr.width / 2 - tw / 2,
};
top = sr.top + sr.height + TOOLTIP_OFFSET;
left = sr.left + sr.width / 2 - tw / 2;
break;
}

// Clamp within viewport so tooltip never overflows
top = Math.max(TOOLTIP_OFFSET, Math.min(top, vh - th - TOOLTIP_OFFSET));
left = Math.max(TOOLTIP_OFFSET, Math.min(left, vw - tw - TOOLTIP_OFFSET));

return { top, left };
}

interface SpotlightProps {
Expand Down