Skip to content

fix: improve empty space utilization below upload box with keyboard s…#782

Open
matheusmurkdock wants to merge 3 commits into
magic-peach:mainfrom
matheusmurkdock:bug/774-improve-empty-space-util-under-upload-box
Open

fix: improve empty space utilization below upload box with keyboard s…#782
matheusmurkdock wants to merge 3 commits into
magic-peach:mainfrom
matheusmurkdock:bug/774-improve-empty-space-util-under-upload-box

Conversation

@matheusmurkdock

Copy link
Copy Markdown

Description

Fixed the empty space utilization issue below the upload box by replacing the generic "Upload a video to get started" text with a useful keyboard shortcuts panel. Also reduced the DropZone padding from py-12 to py-8 for a more compact layout.

Changes:

  • src/components/FileUpload.tsx: Reduced DropZone vertical padding
  • src/components/VideoEditor.tsx: Added keyboard shortcuts panel (Ctrl+O, Space, M, Esc)
  • removed the redundant and repeated line of supported formats
    This makes the empty space functional by helping users discover keyboard shortcuts while maintaining a minimalist design aesthetic.

Related Issue

Closes #774

Type of Contribution

  • Bug fix
  • New feature
  • GSSoC contribution

Participant Info

Recording:

before-
Screenshot 2026-05-20 at 10 37 44 AM
after-
Screenshot 2026-05-20 at 10 37 53 AM

screen-recording-reframe.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above

@vercel

vercel Bot commented May 20, 2026

Copy link
Copy Markdown

@matheusmurkdock is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @matheusmurkdock!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @matheusmurkdock

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:feature New feature gssoc'26 GirlScript Summer of Code 2026 labels May 20, 2026
@magic-peach

Copy link
Copy Markdown
Owner

@matheusmurkdock please resolve conflicts

@matheusmurkdock

Copy link
Copy Markdown
Author

@magic-peach i have resolved the merge conflict in the file.

@magic-peach magic-peach added the level:beginner Beginner level - 20 pts label May 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity.

If you need help with this PR, please comment or ping a maintainer.
Make sure your branch is rebased onto main and all CI checks pass.

@github-actions github-actions Bot added the needs-fixes PR has issues that need to be fixed label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts level:beginner Beginner level - 20 pts needs-fixes PR has issues that need to be fixed type:bug Bug fix type:design UI/UX design type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Improve empty space utilization below the upload box

2 participants