Skip to content

Conversation

@AmirAref
Copy link
Contributor

add birthday and interests fields

add birthday and interests fields
@AmirAref AmirAref requested a review from Copilot May 28, 2025 14:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds birthday and interests fields to the resume parser models.

  • Introduces a new birthday attribute in Resume.Basic
  • Defines an Intereset class and adds interests to ResumeParser
  • Removes cache-prefix from CI workflow steps

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
magicalapi/types/resume_parser.py Added birthday, introduced Intereset, and updated ResumeParser.
.github/workflows/tests.yml Removed cache-prefix setting from the setup-uv job.
.github/workflows/release.yml Removed cache-prefix setting from the setup-uv job.
Comments suppressed due to low confidence (5)

magicalapi/types/resume_parser.py:36

  • New field birthday is added to the Basic model but no tests cover its parsing or validation. Consider adding unit tests for this field.
birthday: str

magicalapi/types/resume_parser.py:67

  • Typo in class name Intereset; rename it to Interest to match the domain concept.
class Intereset(BaseModelValidated, OptionalModel):

magicalapi/types/resume_parser.py:80

  • Update the type annotation to reference the corrected class name (e.g., list[Interest]).
interests: list[Intereset]

.github/workflows/tests.yml:36

  • Removing the cache-prefix may disable version-specific caching and slow down CI. Confirm if this change is intentional.
-        cache-prefix: ${{ matrix.python-version }}

.github/workflows/release.yml:62

  • As in tests.yml, removing cache-prefix here could degrade caching efficiency in release workflows; verify this aligns with your CI strategy.
-          cache-prefix: ${{ matrix.python-version }}

@AmirAref AmirAref merged commit 77905c7 into master May 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants