fix: set baseUrl for GitHub Pages project site#56
Merged
Conversation
GitHub Pages serves project repos at /<repo-name>/, so the default baseUrl must match to resolve assets and internal links correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baseUrlto/magma-documentation/to match GitHub Pages project site URL structure (magma.github.io/magma-documentation/)DOCUSAURUS_BASE_URLenv var can still override it for other deployment targetsContext
GitHub Pages serves project repositories at
/<repo-name>/. The previous default of/caused assets and internal links to resolve incorrectly when deployed tomagma.github.io/magma-documentation/.Test plan
magma.github.io/magma-documentation/docker compose up dev) still works (uses env var override or/fallback)