Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135
Fixes #136
The constraint fields partial rendered a
component_modelblock for every space, inside every manifest, for every constraint, and hidden containers are still submitted. With ~530 spacesedittimed out, and the POST crossed Rack's 4096 parameter limit from the 4th constraint on, so sets could no longer be saved.Now only the block for the space each constraint points at is rendered, and a space's components are loaded on demand from a new admin endpoint. Parameters per constraint go from
3 + 2K + 2Mto5 + 2K(K manifests, M spaces).Safe because the server only reads the
subject_modelentry matching the selected manifest and thecomponent_modelentry matching the selectedsubject_id.35 spaces, 2 constraints, on
edit:form.translation-sets-form [name]form.translation-sets-form selectDecidim::Component LoadqueriesWith 10 constraints and 30 spaces the constraint fields stay at 70 (was ~650).
Covered by endpoint specs,
editregression specs, update specs with 10 constraints, and ajs: truesystem spec.