Skip to content

[CLICK-933] [CLICK-947] ZIndex fix + extended DropdownMenuItem and ProductMenuItem interfaces#44

Merged
LookerClocker merged 19 commits intomasterfrom
CLICK-947
Mar 30, 2026
Merged

[CLICK-933] [CLICK-947] ZIndex fix + extended DropdownMenuItem and ProductMenuItem interfaces#44
LookerClocker merged 19 commits intomasterfrom
CLICK-947

Conversation

@LookerClocker
Copy link
Copy Markdown
Collaborator

@LookerClocker LookerClocker commented Mar 27, 2026

Summary

Extended ProductMenuItem and DropdownMenuItem to accepts html attribute like 'tabIndex', 'role', etc. And increased z-index prop for ConfirmationWindow. Since it was overlapped with SignIn modal.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔧 Component enhancement
  • 📚 Documentation update
  • 🎨 Style/UI changes
  • ⚙️ Misc

Component(s) Affected

  • New component: ComponentName
  • Modified component: ComponentName
  • Removed component: ComponentName

Changes Made

Testing

  • Unit tests added/updated
  • Storybook stories added/updated
  • Manual testing completed
  • Accessibility testing performed
  • Cross-browser testing (if applicable)
  • Responsive design testing (if applicable)

Storybook

  • New stories created for new components
  • Existing stories updated to reflect changes
  • All component variants documented
  • Props table is accurate and complete
  • Examples demonstrate proper usage

Breaking Changes

Screenshots/Videos

TODO

  • ...

Checklist

  • Code is properly formatted (Prettier/ESLint)
  • All commits are signed
  • TypeScript types are properly defined
  • Components follow design system guidelines
  • Accessibility requirements met (WCAG compliance)
  • Bundle size impact considered
  • Tests included/updated or not needed
  • Storybook stories included/updated or not needed
  • Documentation updated or not required
  • No console errors or warnings
  • Backward compatibility maintained (or breaking changes documented)

@LookerClocker LookerClocker changed the title Click 947 ZIndex fix WIP [CLICK-933] [CLICK-947] ZIndex fix + extended DropdownMenuItem and ProductMenuItem interfaces Mar 27, 2026
@LookerClocker LookerClocker self-assigned this Mar 27, 2026
Copy link
Copy Markdown
Member

@davidatwhiletrue davidatwhiletrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LookerClocker LookerClocker force-pushed the CLICK-947 branch 3 times, most recently from 8511e45 to c9e34ef Compare March 30, 2026 11:56
@LookerClocker LookerClocker merged commit 0c4ef00 into master Mar 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants