test(desktop): 补齐 localDb 夹具缺失的 sessions.writable_dirs 列 - #3842
Merged
MagicLizi merged 1 commit intoSep 3, 2026
Merged
Conversation
makecindy#3587 给 sessions schema 新增 writable_dirs 列后,drizzle 的全列查询 会让三个手工 CREATE TABLE 的测试(orcaTeamStore / sessionAutoTitlePersist / sessionsRestoreIfArchived)报 no such column。按兄弟夹具 sessionsUpdate.test.ts 已有写法补上该列,恢复 related 门禁。 从 PR makecindy#3829 拆出:与侧栏 UI 建议稿正交,独立放行。 Signed-off-by: sakiko-toyokawa <203236246+sakiko-toyokawa@users.noreply.github.com>
20 tasks
|
| Filename | Overview |
|---|---|
| apps/desktop/src/main/localDb/tests/orcaTeamStore.test.ts | 为手工创建的 sessions 表补充默认值与当前 schema 一致的 writable_dirs 列,未发现问题。 |
| apps/desktop/src/main/localDb/ipc/tests/sessionAutoTitlePersist.test.ts | 为自动标题持久化测试夹具补充 writable_dirs 列,声明与其他目录字段及 PR 目标一致。 |
| apps/desktop/src/main/localDb/ipc/tests/sessionsRestoreIfArchived.test.ts | 为归档会话恢复测试夹具补充 writable_dirs 列,未引入运行时或测试语义风险。 |
Reviews (1): Last reviewed commit: "test(desktop): 补齐 localDb 夹具缺失的 sessions..." | Re-trigger Greptile
MagicLizi
approved these changes
Sep 3, 2026
MagicLizi
left a comment
Contributor
There was a problem hiding this comment.
代码重审通过:当前 head 把 sessions 测试夹具补上 writable_dirs TEXT NOT NULL DEFAULT '[]',与 schema / 0099 companion 一致,无生产路径改动,没有 P0/P1。全部 conversation 已 resolve。
Contributor
|
三处 sessions 夹具补上 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这次改了什么
摘要
#3587 给
sessionsschema 新增writable_dirs列后,drizzle 的全列查询使三个手工CREATE TABLE的测试夹具(orcaTeamStore/sessionAutoTitlePersist/sessionsRestoreIfArchived)持续报no such column: sessions.writable_dirs,pnpm test:unit:related门禁因此常红。本 PR 按兄弟夹具sessionsUpdate.test.ts已有写法为三处补上writable_dirs TEXT NOT NULL DEFAULT '[]',每处一行,共 3 行。纯测试夹具维护,无生产代码改动。从 PR #3829 拆出(review 意见:与侧栏 UI 决策正交,独立放行)。
变更类型
feat新功能fix缺陷修复refactor/perf重构或性能优化docs/test/chore文档、测试或工程维护范围
UI 变化
不涉及:纯测试夹具改动,无 UI 代码路径变更。
怎么验证的
自动验证
手工验证
不涉及。
未执行的验证
无。
风险
风险分类
影响与回滚
提交前检查
git commit -s,见 DCO)